Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid the hook frame in mysqli connection error tracking #2937

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Nov 7, 2024

Otherwise the error stems from "Mysqli/MysqliIntegration.php:379" which may be confusing and seemingly hint at a problem in our integrations.

Otherwise the error stems from "Mysqli/MysqliIntegration.php:379" which may be confusing and seemingly hint at a problem in our integrations.
@bwoebi bwoebi requested a review from a team as a code owner November 7, 2024 17:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (a9d4274) to head (8ca7d66).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2937      +/-   ##
============================================
+ Coverage     78.28%   82.08%   +3.80%     
  Complexity     2527     2527              
============================================
  Files           135      108      -27     
  Lines         14398    10360    -4038     
  Branches        989        0     -989     
============================================
- Hits          11271     8504    -2767     
+ Misses         2584     1856     -728     
+ Partials        543        0     -543     
Flag Coverage Δ
appsec-extension ?
tracer-php 82.08% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../DDTrace/Integrations/Mysqli/MysqliIntegration.php 87.02% <100.00%> (+0.10%) ⬆️

... and 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d4274...8ca7d66. Read the comment docs.

@pr-commenter
Copy link

pr-commenter bot commented Nov 7, 2024

Benchmarks [ tracer ]

Benchmark execution time: 2024-11-07 17:40:02

Comparing candidate commit 8ca7d66 in PR branch bob/mysqli_error_stack with baseline commit a9d4274 in branch master.

Found 4 performance improvements and 3 performance regressions! Performance is the same for 171 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileBaseline-opcache

  • 🟥 execution_time [+84.377µs; +207.603µs] or [+2.874%; +7.072%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟥 execution_time [+104.232µs; +214.568µs] or [+3.217%; +6.623%]

scenario:LogsInjectionBench/benchLogsInfoBaseline-opcache

  • 🟩 execution_time [-80.762ns; -36.238ns] or [-5.051%; -2.266%]

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+14.849µs; +15.836µs] or [+8.356%; +8.911%]

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟩 execution_time [-14.870µs; -13.924µs] or [-7.703%; -7.213%]

scenario:TraceFlushBench/benchFlushTrace-opcache

  • 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-10.203µs; -5.397µs] or [-5.296%; -2.802%]

@bwoebi bwoebi merged commit 68f8558 into master Nov 8, 2024
669 of 690 checks passed
@bwoebi bwoebi deleted the bob/mysqli_error_stack branch November 8, 2024 11:47
@github-actions github-actions bot added this to the 1.5.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants